-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
dev-cmd/tap-new: add Brewfile documentation to readme template #17256
Conversation
It would be helpful for taps to document how they are to be used with `Brewfile`. Adding documentation for formulae installation to the generated tap readme would help ensure that new taps have this helpful documentation in their repos from the start.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea, thanks @jasonkarns.
@Homebrew/maintainers any objections?
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Good suggested changes @MikeMcQuaid . I'll update the cask-fonts tap PR to match. |
Quick aside question: I haven't frequently made changes to brew itself (it's been a long while). The PR template requests running (And is this already clarified somewhere that I should have noticed?) |
This 👍🏻
This 👍🏻 |
It would be helpful for taps to document how they are to be used with
Brewfile
.Adding documentation for formulae installation to the generated tap readme would help ensure that new taps have this helpful documentation in their repos from the start.
This is primarily a follow-up to Homebrew/homebrew-cask-fonts#9359 which itself was opened after I spent a significant amount of time trying to figure out how to get a font installed as part of my Brewfile.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?