attestation: drop workflow check on core attestation #17331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This follows the workflow changes I made in homebrew-core:
With those changes, (hopefully) all of our bottle-uploading workflows now produce provenance. However, this means we no longer have a single workflow to verify on. As a result, this change relaxes the check to allow any attestation from
Homebrew/homebrew-core
, not just ones from the original publish workflow. I've left a detailed comment on how to ratchet this back down, but I figured I'd fix the verification failure first and then work on that 🙂(This should not meaningfully impact the security model, since an attacker would still need to obtain access to an OIDC credential within the context of
homebrew-core
.)