Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: clarify upstream taps #17345

Merged
merged 1 commit into from
May 22, 2024
Merged

docs: clarify upstream taps #17345

merged 1 commit into from
May 22, 2024

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR clarifies language on upstream taps. Upstream taps are not "official", and should not be referred to as such.

Signed-off-by: Patrick Linnane <patrick@linnane.io>
@p-linnane p-linnane added the documentation Documentation changes label May 22, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed 👍🏻

@MikeMcQuaid MikeMcQuaid merged commit c5fba87 into master May 22, 2024
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the upstream-taps-docs branch May 22, 2024 14:35
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
documentation Documentation changes outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants