Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: allow not validating SBOM #17368

Merged
merged 3 commits into from
May 26, 2024
Merged

Conversation

SMillerDev
Copy link
Member

@SMillerDev SMillerDev commented May 26, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Should solve some error messages when people do not have this gem installed.

This comment was marked as resolved.

@request-info request-info bot added the needs response Needs a response from the issue/PR author label May 26, 2024
@SMillerDev SMillerDev removed the needs response Needs a response from the issue/PR author label May 26, 2024
Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
@SMillerDev
Copy link
Member Author

It seems we need a can_validate?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Let's just make this a boolean, like all ? suffixed methods should be. I don't think it makes sense to use nil for purity's sake when it just makes the code more complex and less idiomatic.

@MikeMcQuaid MikeMcQuaid enabled auto-merge May 26, 2024 14:29
@MikeMcQuaid MikeMcQuaid merged commit 610b80e into master May 26, 2024
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the fix/sbom/no_error_missing_validation branch May 26, 2024 14:39
@MikeMcQuaid
Copy link
Member

Thanks @SMillerDev!

@github-actions github-actions bot added the outdated PR was locked due to age label Jun 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants