workflows/docs: various tweaks. #17468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MikeMcQuaid
commented
Jun 11, 2024
•
MikeMcQuaid
commented
- don't limit the entire job to Homebrew/brew (so it can be synced by Homebrew/.github sync jobs)
- always checkout the current repository (as it may not be Homebrew/brew and, when it is, it doesn't take too long anyway)
- only need to do cleanup for Homebrew/brew
- run Vale as separate step
- fix working directory handling
MikeMcQuaid
force-pushed
the
docs_ci_tweaks
branch
from
3cddc6f to
833a74f
Compare
- don't limit the entire job to Homebrew/brew (so it can be synced by Homebrew/.github sync jobs) - always checkout the current repository (as it may not be Homebrew/brew and, when it is, it doesn't take too long anyway) - only need to do cleanup for Homebrew/brew - run Vale as separate step - fix working directory handling
MikeMcQuaid
force-pushed
the
docs_ci_tweaks
branch
from
833a74f to
0fc7cd9
Compare
SMillerDev
approved these changes
Jun 11, 2024
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.