Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix ZDOTDIR environment variable not being read #17483

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix ZDOTDIR environment variable not being read #17483

merged 1 commit into from
Jun 12, 2024

Conversation

leoheitmannruiz
Copy link
Contributor

@leoheitmannruiz leoheitmannruiz commented Jun 12, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

% echo $ZDOTDIR
/Users/leo/.config/zsh
% brew info openjdk | grep echo
  echo 'export PATH="/opt/homebrew/opt/openjdk/bin:$PATH"' >> ~/.zshrc

ZDOTDIR is supposed to be read, but as it's not on the "allow list", it isn't. At least, that's my understanding.

I just copied what has been done for TMUX:

% grep -nr TMUX
brew/bin/brew:180:  TMUX
brew/Library/Homebrew/caveats.rb:186:    if ENV["HOMEBREW_TMUX"] && !quiet_system("/usr/bin/pbpaste")

But I can also instead add it to ENV_VAR_NAMES, if that is desired.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @leoheitmannruiz! One test looks like it needs fixed here but good to 🚢 when 🟢

@MikeMcQuaid MikeMcQuaid enabled auto-merge June 12, 2024 15:02
@MikeMcQuaid MikeMcQuaid merged commit dbe0374 into Homebrew:master Jun 12, 2024
25 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants