cask/audit: support on_os blocks in audit_min_os #17548
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?As suggested in Homebrew/homebrew-cask#176710, this PR does the following:
MacOSRequirement
, adds and testsminimum_version
to return the minimum OS version allowed by adepends_on macos:
stanzaOnSystem
, adds@on_system_block_min_os
which is made available viacask/dsl.rb
for fetching the minimum OS version of the current system-specific blockCask::Audit#audit_min_os
:depends_on
stanza (and adjust the associated error message to match)depends_on
array of allowed OS versions by callingminimum_version
instead ofversion
This should help us notice when a cask version bump introduces a new minimum OS requirement.