Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

formula_auditor: scope eol check to core tap #17553

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

apainintheneck
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is not relevant information for third-party taps and requires network requests to endoflife.date so it's best to avoid them in this case.

Closes #17531

CC: @colindean

This is not relevant information for third-party taps and requires
network requests to `endoflife.date` so it's best to avoid them
in this case.

Closes #17531
Copy link
Contributor

@colindean colindean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, 👍

@apainintheneck apainintheneck merged commit c53f600 into master Jun 23, 2024
25 checks passed
@apainintheneck apainintheneck deleted the scope-eol-audit-to-core-tap branch June 23, 2024 04:42
@MikeMcQuaid
Copy link
Member

Thanks @apainintheneck!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"brew audit --online" shouldn't check endoflife.date for private taps
4 participants