Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

extract: Add the --git-revision argument #17588

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

Kentzo
Copy link
Contributor

@Kentzo Kentzo commented Jun 28, 2024

When pinning formula alongside its dependencies it's important to limit the search scope.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@Kentzo Kentzo force-pushed the extract-revision branch 2 times, most recently from 5eb9b66 to bd1774d Compare June 28, 2024 23:04
@Bo98
Copy link
Member

Bo98 commented Jun 28, 2024

Maybe should be called --git-revision instead so it doesn't get confused for formula revision.

@Kentzo Kentzo force-pushed the extract-revision branch 2 times, most recently from a0f9d0b to d1bb4db Compare June 29, 2024 00:43
When pinning formula alongside its dependencies it's important to limit
the search scope.
@Kentzo Kentzo force-pushed the extract-revision branch from d1bb4db to be48b47 Compare June 29, 2024 00:45
@Kentzo Kentzo changed the title extract: Add the --revision argument extract: Add the --git-revision argument Jun 29, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @Kentzo!

@MikeMcQuaid MikeMcQuaid enabled auto-merge June 30, 2024 18:27
@MikeMcQuaid MikeMcQuaid merged commit ab2b3d5 into Homebrew:master Jun 30, 2024
25 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants