Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

livecheck: finish expanding typed: strict #17643

Merged
merged 1 commit into from
Jul 8, 2024
Merged

livecheck: finish expanding typed: strict #17643

merged 1 commit into from
Jul 8, 2024

Conversation

samford
Copy link
Member

@samford samford commented Jul 6, 2024 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I previously expanded use of typed: strict in livecheck files but the exception was livecheck/strategy.rb. This addresses the @strategies type errors in that file and upgrades it to typed: strict.

Related to #17297.

@samford samford force-pushed the livecheck/expand-typed-strict-2 branch from 91f4cf0 to d8a4b02 Compare July 7, 2024 11:51
@samford @apainintheneck
livecheck: finish expanding typed: strict
17d1561 
I previously expanded use of `typed: strict` in livecheck files but
the exception was `livecheck/strategy.rb`. This addresses the
`@strategies` type errors in that file and upgrades it to
`typed: strict`.

Co-authored-by: apainintheneck <apainintheneck@gmail.com>
@samford samford force-pushed the livecheck/expand-typed-strict-2 branch from d8a4b02 to 17d1561 Compare July 8, 2024 02:05
@samford samford mentioned this pull request Jul 8, 2024
Merged
7 tasks
MikeMcQuaid
MikeMcQuaid approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @samford!

@MikeMcQuaid MikeMcQuaid enabled auto-merge July 8, 2024 12:07
@MikeMcQuaid MikeMcQuaid merged commit 341130f into Homebrew:master Jul 8, 2024
25 checks passed
@samford samford deleted the livecheck/expand-typed-strict-2 branch July 8, 2024 13:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dduugg dduugg dduugg left review comments

@apainintheneck apainintheneck apainintheneck left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samford @MikeMcQuaid @dduugg @apainintheneck