Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Have tap_git_head return nil when no tap is installed #17763

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Jul 15, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes Homebrew/discussions#5493

When the API is not being used but the core/cask taps aren't installed, tap_git_head will error on homebrew/core and homebrew/cask. This PR catches that error and returns nil. I think this should be fine since I scanned the code and it seemed like there wasn't much that should break, but it is posisble that I missed something.

Also, if desired, we could scope this to homebrew/core and homebrew/cask

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Rylan12 Rylan12 merged commit 86bf1ea into master Jul 15, 2024
24 checks passed
@Rylan12 Rylan12 deleted the fix-tap-git-head branch July 15, 2024 18:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants