Fix UID handling with cask installer script:
#17782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
force-pushed
the
system_command-uid
branch
3 times, most recently
from
e0278f3 to
f9726db
Compare
carlocab
approved these changes
Jul 17, 2024
carlocab
approved these changes
Jul 17, 2024
carlocab
added a commit
that referenced
this pull request
Jul 17, 2024
Source builds that use Git checkouts with submodules can choke when the process UID does not match its EUID. We can fix this by using the `reset_uid` option added in #17782.
7 tasks
|
Great work here, thanks @Bo98! |
ctaintor
pushed a commit
to ctaintor/brew
that referenced
this pull request
Sep 4, 2024
Source builds that use Git checkouts with submodules can choke when the process UID does not match its EUID. We can fix this by using the `reset_uid` option added in Homebrew#17782.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broadly speaking, Homebrew respects EUID and writes all files using that EUID.
When using
installer script:this contract may not necessarily be true for third-party scripts, leading to permission issues under setups where EUID != UID. For example, bash scripts by default will respect UID instead unless you use Bash protected mode (bash -p).In formulae, we already handle this here:
brew/Library/Homebrew/utils/fork.rb
Line 48 in 2cdc092
This PR adds the same to casks via a
reset_uidsystem_commandoption. Unfortunately Open3 isn't flexible enough to handle this so we need to replace it with our own implementation.