-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Formula-Cookbook: add std_npm_args
#17881
Conversation
21da735
to
552e24c
Compare
Style was failing unless I put |
Signed-off-by: Patrick Linnane <patrick@linnane.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate this critique should have probably landed in the prior PR but: my concern with documentation like this is it inevitably results in the docs and the code becoming out of sync. What would you think about adjusting the docs to link to the code instead?
@MikeMcQuaid So remove the actual listed args, and just have a list of |
Or the online documentation, e.g. https://rubydoc.brew.sh/Formula.html#std_configure_args-instance_method. Some of it sucks though (e.g. https://rubydoc.brew.sh/Formula.html#std_cmake_args-instance_method) I'm also not opposed to ripping it all out and just referencing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok for feedback to be fixed in succeeding PRs.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Adds the new
std_npm_args
to the Formula Cookbook.