Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Relax cask token regex. #18009

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Aug 10, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The audit was relaxed in #17562, but we cannot actually load casks containing e.g. + yet.

Needed for Homebrew/homebrew-cask#182101.

Copy link
Contributor

@apainintheneck apainintheneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense since it makes HOMEBREW_TAP_CASK_TOKEN_REGEX functionally equivalent to HOMEBREW_TAP_FORMULA_NAME_REGEX (the only difference being the name of the named capture) and they already share the same audit (see Library/Homebrew/formula_name_cask_token_auditor.rb).

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @reitermarkus!

@MikeMcQuaid MikeMcQuaid merged commit 457a408 into Homebrew:master Aug 12, 2024
24 checks passed
@reitermarkus reitermarkus deleted the token-auditor branch August 12, 2024 08:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants