Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make Cask::Artifact::Installer typesafe #18020

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Make Cask::Artifact::Installer typesafe #18020

merged 1 commit into from
Aug 12, 2024

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Aug 12, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Cask::Artifact::Installer instances would previously extend a module based on whether they were initialized with a manual flag. Instead, the flag is recorded and the logic is moved within the affected method (install_phase). I think this is much more idiomatic ruby, and it also removes the T.unsafe call (the TODO that suggests it could be removed no longer applied).

@apainintheneck apainintheneck added the cask Homebrew Cask label Aug 12, 2024
@carlocab carlocab requested a review from a team August 12, 2024 06:29
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @dduugg!

@dduugg dduugg merged commit 32107f2 into master Aug 12, 2024
24 checks passed
@dduugg dduugg deleted the installer-safety branch August 12, 2024 20:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cask Homebrew Cask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants