Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cask/dsl/caveats: fix rosetta caveat printing #18021

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented Aug 12, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is the third (and hopefully final) attempt to get the Rosetta caveat for Casks printing correctly.
The conditional in the if statement was changed in a previous PR, however this results in the caveat never printing when the architecture is simulated in audits (because the first half of the check returns first).

Homebrew::SimulateSystem.current_arch will be set correctly whether the system is being "simulated" or not. This mirrors the current logic in audit_rosetta.


Unblocks Homebrew/homebrew-cask#181053

@carlocab carlocab enabled auto-merge August 12, 2024 06:59
@carlocab carlocab merged commit c23c367 into Homebrew:master Aug 12, 2024
24 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants