Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

devcontainer: Tap bundle and services in Codespaces #18078

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Aug 18, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  • Yes, I wanted to do more Homebrew stuff from Codespaces on my iPad because I couldn't be bothered to get out of bed and walk downstairs to get my laptop.
  • For that I needed my Homebrew/brew branch and brew services tapped, with sufficient permissions for write access so I could push commits.
  • So I thought I'd do bundle as well as it seemed like another "would maybe use Codespaces for this" tap.

- Yes, I wanted to do more Homebrew stuff from Codespaces on my iPad
  because I couldn't be bothered to get out of bed and walk downstairs
  to get my laptop.
- For that I needed my `Homebrew/brew` branch and `brew services`
  tapped, with sufficient permissions for write access so I could
  push commits.
- So I thought I'd do `bundle` as well as it seemed like another
  "would maybe use Codespaces for this" tap.
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks!

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks @issyl0!

@MikeMcQuaid MikeMcQuaid merged commit 3426911 into master Aug 19, 2024
24 checks passed
@MikeMcQuaid MikeMcQuaid deleted the codespaces-more-taps branch August 19, 2024 08:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants