Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make Cask::Artifact::Installer typesafe #18080

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Make Cask::Artifact::Installer typesafe #18080

merged 1 commit into from
Aug 19, 2024

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Aug 18, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is a re-apply of #18020 now that the downstream fix is in. (I have searched the Homebrew org for any other references to the deleted modules, but that was the only one I found.)

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab carlocab merged commit 3e725e7 into master Aug 19, 2024
24 checks passed
@carlocab carlocab deleted the installer-safety branch August 19, 2024 07:22
@MikeMcQuaid
Copy link
Member

Thanks @dduugg!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants