Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test/download_strategies/abstract_spec: fix test #18966

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 19, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Mktemp.new doesn't run anything so test was skipped.

Could use Mktemp.new(...).run instead but most tests already use mktmpdir

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Dec 20, 2024
@MikeMcQuaid
Copy link
Member

Thanks!

Merged via the queue into master with commit 2e12fd2 Dec 20, 2024
28 checks passed
@MikeMcQuaid MikeMcQuaid deleted the download_strategies/abstract-fix-test branch December 20, 2024 08:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants