Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ast_constants: order deprecate! before disable! #18974

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Dec 20, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Based on comments in other PRs, seems like deprecate! prior to disable! is the more logical order.

@cho-m cho-m marked this pull request as ready for review December 20, 2024 20:18
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed this is better, thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Dec 23, 2024
Merged via the queue into master with commit d5e1b51 Dec 23, 2024
28 checks passed
@MikeMcQuaid MikeMcQuaid deleted the deprecate-disable-order branch December 23, 2024 17:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants