Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix prerelease check to allow standard release #19008

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

daeho-ro
Copy link
Member

@daeho-ro daeho-ro commented Dec 27, 2024

I think my previous PR broke the version check logic,

Here is the failed actions

and noticed that the exception should exist. 😥


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Dec 27, 2024
@MikeMcQuaid
Copy link
Member

Thanks @daeho-ro!

Merged via the queue into Homebrew:master with commit 69849e1 Dec 27, 2024
28 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants