Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Document stderr redirection for shell_output tests #19120

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

in0rdr
Copy link
Contributor

@in0rdr in0rdr commented Jan 19, 2025

As discussed in Homebrew/homebrew-core#204366, this documents the specific case, where your program writes an error to stderr that needs to be checked in a test (e.g., using assert_match and shell_output):

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Have suggested a rewording here.

Document the specific case, where your program writes an error to stderr
that needs to be checked in a test (e.g., using `assert_match` and
`shell_output`):
* #5149

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@in0rdr in0rdr force-pushed the feat/document-stderr-redirect branch from a3df930 to 8fa2119 Compare January 19, 2025 15:28
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @in0rdr, you rock!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jan 19, 2025
Merged via the queue into Homebrew:master with commit 55f399c Jan 19, 2025
28 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants