cleanup: improve cleanup version detection. #19137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
force-pushed
the
cleanup_improve_pinned
branch
2 times, most recently
from
1abb526 to
5f72fdb
Compare
We're using `formula.eligible_kegs_for_cleanup` to figure out which formula should be kept or removed based on e.g. `brew pin` status but we didn't use this sufficiently in `brew cleanup` to avoid cleaning up all cached files related to a pinned keg. Instead, let's use a (cached) call to `formula.eligible_kegs_for_cleanup` to ensure that we check all related resources, manifests, etc. for pinned bottles rather than just the latest version.
MikeMcQuaid
force-pushed
the
cleanup_improve_pinned
branch
from
5f72fdb to
fa8ada3
Compare
p-linnane
approved these changes
Jan 23, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using
formula.eligible_kegs_for_cleanupto figure out which formula should be kept or removed based on e.g.brew pinstatus but we didn't use this sufficiently inbrew cleanupto avoid cleaning up all cached files related to a pinned keg.Instead, let's use a (cached) call to
formula.eligible_kegs_for_cleanupto ensure that we check all related resources, manifests, etc. for pinned bottles rather than just the latest version.