Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use -march=native for non-bottle source builds [Linux] #5505

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

sjackman
Copy link
Contributor

@sjackman sjackman commented Jan 8, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Use -march=native for source builds on Linux. Brew currently uses -march=core2 by default for both bottle and source builds. Previous behaviour was -march=core2 for bottle builds and -march=native for source builds.

@sjackman sjackman self-assigned this Jan 8, 2019
@sjackman sjackman requested review from MikeMcQuaid and reitermarkus and removed request for MikeMcQuaid January 8, 2019 17:49
@MikeMcQuaid MikeMcQuaid merged commit e0342ac into Homebrew:master Jan 8, 2019
@MikeMcQuaid
Copy link
Member

Thanks again @sjackman!

@sjackman sjackman deleted the march-native-linux branch January 8, 2019 19:17
@sjackman
Copy link
Contributor Author

sjackman commented Jan 8, 2019

Thanks for merging, Mike!

@lock lock bot added the outdated PR was locked due to age label Feb 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 7, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants