Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix manpage auto-discovery links for gnubin-enabled formulae #176589

Merged
merged 26 commits into from
Jul 18, 2024

Conversation

gromgit
Copy link
Contributor

@gromgit gromgit commented Jul 7, 2024

Followup to #35874, which no longer works because the macOS man discovery logic seems to have changed. The new link location (.../gnubin/man) works across macOS and Linux man.

This PR depends on Homebrew/brew#17633 to properly function for most users.

Closes #176037.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting? (no testable changes)
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Copy link

@injust injust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed libtool and uutils-coreutils (I searched for libexec.install_symlink "=> \"man\"").

For libtool, was there a reason for the symlink to exist on macOS but not Linux? That isn't consistent with the other symlinks.

@gromgit
Copy link
Contributor Author

gromgit commented Jul 9, 2024

Thanks for the catch, @injust! I'll update this PR after #176809 is committed, otherwise this one will error out.

@gromgit
Copy link
Contributor Author

gromgit commented Jul 9, 2024

@Homebrew/core, could use some help here. CI is complaining about undeclared cached linkages to acl (no idea how that formula's involved) and "can't bottle gnu-tar because we've already installed it" (chicken-n-egg?).

@Bo98
Copy link
Member

Bo98 commented Jul 9, 2024

The fix for gnu-tar will be to make test-bot to build that first but given its rare to rebuild gnu-tar in a multi-formula PR (this is the first time this has happened in many years) it may just be easier and better use of time to just separate that to another PR.

@gromgit
Copy link
Contributor Author

gromgit commented Jul 10, 2024

separate that to another PR

OK thanks, @Bo98, I'll try that.

@gromgit
Copy link
Contributor Author

gromgit commented Jul 10, 2024

OK, now I'm confused. I dropped gnu-tar from this PR, and the latest commit chain seems to confirm that, so why is test-bot still processing it? Do I need to start a new PR?

@MikeMcQuaid
Copy link
Member

Have restarted this to see. CC @carlocab in case you know the answer to @gromgit's question.

@ZhongRuoyu ZhongRuoyu added CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. long dependent tests Set a long timeout for dependent testing labels Jul 14, 2024
Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gromgit!

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 18, 2024
@BrewTestBot BrewTestBot enabled auto-merge July 18, 2024 23:29
@ZhongRuoyu
Copy link
Member

Rebased to resolve conflicts with 8aa83b3. No rebuild needed.

@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 18, 2024
Merged via the queue into Homebrew:master with commit 6b1416f Jul 18, 2024
16 checks passed
@Bo98 Bo98 mentioned this pull request Jul 24, 2024
6 tasks
ZhongRuoyu added a commit that referenced this pull request Jul 24, 2024
This was previously disabled, but opportunistically switched on in
#176589. So let's re-disable it explicitly.

Fixes #178258.
@Mapuppy09
Copy link

i am authorized each one there here help me resolve these issue Thanks!

@gromgit gromgit deleted the fix_manpath branch February 21, 2025 15:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long dependent tests Set a long timeout for dependent testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symbolic link from man to gnuman, etc. does not work
7 participants