-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix manpage auto-discovery links for gnubin
-enabled formulae
#176589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you missed libtool
and uutils-coreutils
(I searched for libexec.install_symlink "=> \"man\""
).
For libtool
, was there a reason for the symlink to exist on macOS but not Linux? That isn't consistent with the other symlinks.
@Homebrew/core, could use some help here. CI is complaining about undeclared cached linkages to |
The fix for |
OK thanks, @Bo98, I'll try that. |
OK, now I'm confused. I dropped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @gromgit!
Rebased to resolve conflicts with 8aa83b3. No rebuild needed. |
i am authorized each one there here help me resolve these issue Thanks! |
Followup to #35874, which no longer works because the macOS
man
discovery logic seems to have changed. The new link location (.../gnubin/man
) works across macOS and Linuxman
.This PR depends on Homebrew/brew#17633 to properly function for most users.
Closes #176037.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting? (no testable changes)brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?