Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create symbolic link man to gnuman #35874

Closed
wants to merge 11 commits into from

Conversation

moonfruit
Copy link
Contributor

@moonfruit moonfruit commented Jan 10, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

For compatible, I simply create symbolic link man which point to gnuman instead of rename it.
Fix #35310.

@fxcoudert
Copy link
Member

We don't need the revision bumps, since the content is otherwise unchanged. Other than that, it's OK.

@fxcoudert
Copy link
Member

Sorry, forgot something else: please make it 1 commit per formula. It makes history easier.

@moonfruit
Copy link
Contributor Author

OK, I will change it.

@apjanke
Copy link
Contributor

apjanke commented Jan 11, 2019

Clever. I tested this out, and it seems to work as intended: when I put the gnubin directory for e.g. sed on my path ahead of /usr/bin, then man sed picks up the GNU man page to correspond to it.

@fxcoudert
Copy link
Member

Thanks @moonfruit

@fxcoudert fxcoudert closed this in ece710d Jan 11, 2019
@moonfruit moonfruit deleted the rename-gnuman branch January 11, 2019 07:54
@lock lock bot added the outdated PR was locked due to age label Feb 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 10, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants