This repository was archived by the owner on Jan 16, 2025. It is now read-only.
mailhog 0.1.8 (new formula) #44884
Closed
mailhog 0.1.8 (new formula) #44884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| test do | ||
| output = shell_output("#{bin}/MailHog -h 2>&1 | head -n 1") |
There was a problem hiding this comment.
Can’t we write a better test than e.g. -h/-help/-version?
There was a problem hiding this comment.
Valid point. Given that MailHog outputs debug messages when run directly, test should check against that.
- Starting "A" removed from formula description - Test updated to check for default ./MailHog output instead of help output - Information about sendmail replacement is displayed after installation, instead of using caveats function.
- Test caused execution expiration as MailHog kept running in the background. Fixed by redirecting the output to /dev/null.
- Text match assertion wrapped in // instead of %r{}.
- Whitespace removed.
- Test caused execution expiration as MailHog kept running in the background. Fixed by killing the process in 3 seconds. - Info message removed as sendmail replacement option is documented on MailHog project page.
|
Is there anything else that needs to be done for this formula to be merged? |
| end | ||
|
|
||
| def install | ||
| mkdir_p "#{buildpath}/src/github.com/mailhog/" |
There was a problem hiding this comment.
Use (buildpath/"src/github.com/mailhog/").mkpath
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MailHog is a Go-based email testing tool for developers.
This formula builds and installs MailHog version 0.1.8.