Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Testing framework: support for extra arguments in node startup #260

Open
paolocappelletti opened this issue May 17, 2021 · 1 comment
Open
Assignees

Comments

@paolocappelletti
Copy link
Collaborator

paolocappelletti commented May 17, 2021

In the testing framework the extra_args parameter is declared but not handled in the method start_sc_node() here:

def start_sc_node(i, dirname, extra_args=None, rpchost=None, timewait=None, binary=None, print_output_to_file=False):

could be useful if we have to pass custom system properties to the node with -D option
Note: as temporary solution I tried to include the -D option in the "binary" argument: this works but does not support values with spaces , as they cause a wrong split of the command line here:

sidechainclient_processes[i] = subprocess.Popen(bashcmd.split())

@i-Alex
Copy link
Contributor

i-Alex commented May 10, 2022

@paolocappelletti is it still a case?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@i-Alex @paolocappelletti and others