Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SidechainHistoryStorage, SidechainHistory data retrieving methods naming #97

Open
i-Alex opened this issue Apr 16, 2020 · 0 comments
Open
Assignees

Comments

@i-Alex
Copy link
Contributor

i-Alex commented Apr 16, 2020

In SidechainHistoryStorage, SidechainHistory and other places when we want and expect to retrieve an instance of A by some B, we should have a method:
def getAbyB(b: B): A
That should return A or throw an exception.

When we expect that A can not exist for existing B, we should have a method:
def getAbyBOption(b: B): Option[A]
At the moment such a method names are not consistent.
Need to review and change in all places, where is needed.

@i-Alex i-Alex removed their assignment May 15, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants