Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Cleanup small issues with lab section #1973

Closed
jackcmeyer opened this issue Apr 6, 2020 · 4 comments · Fixed by #2010
Closed

Cleanup small issues with lab section #1973

jackcmeyer opened this issue Apr 6, 2020 · 4 comments · Fixed by #2010
Labels
🐛bug issue/pull request that documents/fixes a bug in progress indicates that issue/pull request is currently being worked on labs issue/pull request that interacts with labs module LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button)
Milestone
v2.0

Comments

@jackcmeyer
Copy link
Member

🐛 Bug Report

A few minor bugs can be seen in the labs section:

  1. On the new lab screen, the patient typeahead label is showing the internationalization key
  2. On the new lab screen and the view lab screen, the notes field is marked as required when it shouldn't be.
  3. When on the /labs route the following error message appears:
    Warning: Each child in a list should have a unique "key" prop.
@jackcmeyer jackcmeyer added 🐛bug issue/pull request that documents/fixes a bug help wanted indicates that an issue is open for contributions labs issue/pull request that interacts with labs module LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button) labels Apr 6, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Apr 6, 2020
@alti21
Copy link
Contributor

alti21 commented Apr 6, 2020

Can I take this?

@jackcmeyer
Copy link
Member Author

Yes! I've assigned this to you @alti21

@jackcmeyer jackcmeyer added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Apr 6, 2020
@mleralec
Copy link
Contributor

Is @alti21 still on it ? I can take it if not

@alti21
Copy link
Contributor

alti21 commented Apr 23, 2020

Yes I'm still working on it

@jackcmeyer jackcmeyer mentioned this issue Apr 23, 2020
Closed
@alti21 alti21 mentioned this issue Apr 23, 2020
Merged
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
🐛bug issue/pull request that documents/fixes a bug in progress indicates that issue/pull request is currently being worked on labs issue/pull request that interacts with labs module LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button)
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

fix(labs): Cleanup small issues with lab section alti21/hospitalrun-frontend
3 participants
@jackcmeyer @alti21 @mleralec