Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Sidebar should only show links which user has access to see #2110

Closed
jackcmeyer opened this issue May 31, 2020 · 3 comments · Fixed by #2112
Closed

Sidebar should only show links which user has access to see #2110

jackcmeyer opened this issue May 31, 2020 · 3 comments · Fixed by #2112
Assignees
@blestab
Labels
🐛bug issue/pull request that documents/fixes a bug good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button)
Milestone
v2.0

Comments

@jackcmeyer
Copy link
Member

jackcmeyer commented May 31, 2020 •
edited
Loading

🐛 Bug Report

Right now, the sidebar shows all links, no matter what the user has access to see based on their permissions.

Sidebar links should be limited to what the user is allowed to see.
@jackcmeyer jackcmeyer added 🐛bug issue/pull request that documents/fixes a bug help wanted indicates that an issue is open for contributions good first issue indicates an issue is good for a first time contributor LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button) labels May 31, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone May 31, 2020
@blestab
Copy link
Contributor

blestab commented May 31, 2020

I am a little nervous but I would like to try this as my first issue. I have finished going through some reactjs/ts tutorials and have browsed around the repo; I feel I might be able to do this one.

@jackcmeyer
Copy link
Member Author

@blestab sounds great! no need to be nervous :) reach out if you need help!

@jackcmeyer jackcmeyer added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels May 31, 2020
@blestab
Copy link
Contributor

blestab commented May 31, 2020 •
edited
Loading

Thanks @jackcmeyer ,

Looking further into this it looks like i would also have to apply the same fix to the top Navbar (for smaller screen sizes) as well as restrict the 'add new' and 'edit' buttons on the relevant pages such as Patients Listing/View, Appointment Listing/View?

@blestab blestab mentioned this issue Jun 2, 2020
Merged
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@blestab blestab

Labels
🐛bug issue/pull request that documents/fixes a bug good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button)
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

fix(sidebar): sidebar should only show links user has access to see
2 participants
@blestab @jackcmeyer