Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Amethyst-Aura theme to gallery #64

Open
wants to merge 10 commits into
base: hyde-gallery
Choose a base branch
from

Conversation

jackpawlik1
Copy link

A simple yet smooth purple & blue theme.

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Feb 13, 2025

Hi @jackpawlik1 Pleas provide a preview in the theme's readme.

Also please provide a preview in this MR too. create a directory with the theme name and add an image preview. Same as the others.

@jackpawlik1
Copy link
Author

Hi @jackpawlik1 Pleas provide a preview in the theme's readme.

Also please provide a preview in this MR too. create a directory with the theme name and add an image preview. Same as the others.

Hello @kRHYME7, I believe I updated everything properly. My apologies if I didn't, this is the first time working with Github and doing any sort of merge requests! Please let me know if I need to update/fix/do anything else. Thank you.

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Feb 13, 2025

@jackpawlik1 Thank you! I've seen it now on the theme repo. But in order to have preview on theme installation, you should also provide a preview on this repository.

see https://github.com/HyDE-Project/hyde-gallery?tab=readme-ov-file#contributions-for-additional-themes

@jackpawlik1
Copy link
Author

@kRHYME7, ok I believe I did everything properly this time! Had a few issues trying to get the folder & file implemented correctly but the final version looks fine! Again, please bear with me if I didn't do it correctly!

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Feb 13, 2025

@jackpawlik1 thank you! I'll merge this now.

Your README in your theme repo had a wrong link, it should be https://github.com/jackpawlik1/Amethyst-Aura

./themepatcher.sh  "Amethyst Aura" https://github.com/jackpawlik1/Amethyst-Aura

example

cd ~/HyDE/Scripts
./themepatcher.sh  "Amethyst Aura" https://github.com/jackpawlik1/Amethyst-Aura

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Feb 13, 2025

Use the above method to install a theme so you can test your theme.

image


Looks like the theme is still named "MyTheme"

@jackpawlik1
Copy link
Author

@kRHYME7 Man oh man, no idea how that slipped past me. I will do an audit on everything and update before making another request. Thank you.

@@ -398,5 +398,15 @@
"#294052",
"#AACBF0"
]
},
{
"THEME": "Amethyst Aura",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With dash or without? This is the theme name, and should be the same as the directory name

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants