fix: plan too long for status api #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Truncates text at 65400 characters and adds the ability to push entire output to a directory
williamwilson
suggested changes
Feb 18, 2021
.github/workflows/test.yml
Outdated
| @@ -40,6 +40,7 @@ jobs: | |||
| token: ${{ secrets.GITHUB_TOKEN }} | |||
| working-directory: ${{ env.TERRAFORM_WORKING_DIRECTORY }} | |||
| report-title: Single Argument Run | |||
|
|
|||
There was a problem hiding this comment.
nit: extra empty line
src/github.ts
Outdated
| } | ||
|
|
||
| function findLine(wording: string, output: string): string { | ||
| const wordingIndex = output.indexOf('Plan:'); |
There was a problem hiding this comment.
shouldn't this be using the wording parameter?
edwinf
force-pushed
the
truncate-message
branch
from
d502a6e to
c99b7a1
Compare
williamwilson
approved these changes
Feb 18, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Feb 18, 2021
## [1.1.7](v1.1.6...v1.1.7) (2021-02-18) ### Bug Fixes * plan too long for status api ([#18](#18)) ([1a78e7b](1a78e7b))
|
🎉 This PR is included in version 1.1.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncates text at 65400 characters and adds the ability to push entire output to a directory