feat: StatusStripe should respond to font zooming #4243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this also fixes an oversight with font zooming for other icons. for cmd- below the default size, those icons weren’t unzooming this also cleans up zoom.css, avoiding repeated css paths by leveraging scss nesting Fixes kubernetes-sigs#4242
Codecov Report
@@ Coverage Diff @@
## master #4243 +/- ##
==========================================
+ Coverage 59.27% 59.48% +0.20%
==========================================
Files 74 74
Lines 2399 2399
Branches 582 582
==========================================
+ Hits 1422 1427 +5
+ Misses 750 745 -5
Partials 227 227
Continue to review full report at Codecov.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this also fixes an oversight with font zooming for other icons. for cmd- below the default size, those icons weren’t unzooming
this also cleans up zoom.css, avoiding repeated css paths by leveraging scss nesting
Fixes #4242
Description of what you did:
My PR is a:
Please confirm that your PR fulfills these requirements
fix(plugins/plugin-k8s): fixed annoying bugs