Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

optimizer.zero_grad() #58

Open
lingorX opened this issue Jan 12, 2023 · 1 comment
Open

optimizer.zero_grad() #58

lingorX opened this issue Jan 12, 2023 · 1 comment

Comments

@lingorX
Copy link

lingorX commented Jan 12, 2023

Hi,

It seems that optimizer.zero_grad() is forgotten to call here.

Or perhaps I miss something.

@SlongLiu
Copy link
Contributor

SlongLiu commented Feb 2, 2023

Thanks for your good question. It can be viewed as a bug in out implementation, but with little influence on the final performance.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants