Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: changed contigs file for quast-rule to avoid workflow to stop because of low read numbers #338

Merged
merged 6 commits into from
Dec 1, 2021

Conversation

AKBrueggemann
Copy link
Collaborator

Expected commit message structure

Commit messages should be structured as follows:

<type>[optional scope]: <description>

[optional body]

[optional footer]

Type

Must be one of the following:

  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • docs: Documentation only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that neither fixes a bug nor adds a feature
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Examples

Commit message with description and breaking change in body

feat: allow provided config object to extend other configs

BREAKING CHANGE: `extends` key in config file is now used for extending other config files

Commit message with no body

docs: correct spelling of CHANGELOG

Commit message with scope

feat(lang): added polish language

Commit message for a fix using an (optional) issue number.

fix: minor typos in code

see the issue for details on the typos fixed

fixes issue #12

Copy link
Contributor

@thomasbtf thomasbtf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, just one remark :)

"results/{{date}}/assembly/{sample}/{assembler}/{sample}.contigs.fasta".format(
sample=s, assembler=return_assembler(s)
)
"results/{{date}}/contigs/checked/{sample}.fasta".format(sample=s)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change here! But apparently the function get_expanded_contigs is just used in the rule virologist_report. Thus, get_expanded_contigs is kind of obsolete now. Please remove it completely and just use expand_samples_for_date instead.

@thomasbtf
Copy link
Contributor

Top 👍

@thomasbtf thomasbtf force-pushed the low-read-number-fasta branch from c9e8b7c to daa0d79 Compare December 1, 2021 09:34
@AKBrueggemann AKBrueggemann merged commit 2d0e246 into master Dec 1, 2021
@AKBrueggemann AKBrueggemann deleted the low-read-number-fasta branch December 1, 2021 15:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow stops if a fraction of the samples does not meet required number of reads
2 participants