Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

perf: optimisations for ont - barcode+adapter-trimming, primer-trimming (porechop) and read correction (Canu) #454

Merged
merged 15 commits into from
Jan 25, 2022
Merged

perf: optimisations for ont - barcode+adapter-trimming, primer-trimming (porechop) and read correction (Canu) #454

merged 15 commits into from
Jan 25, 2022

Conversation

simakro
Copy link
Collaborator

@simakro simakro commented Jan 21, 2022 •
edited
Loading

Description

perf: Optimizations for barcode+adapter-trimming, primer-trimming (porechop) and read correction (Canu)

Related Issue

Checklist

@thomasbtf
Copy link
Contributor

Hey Simon, thanks for the PR and the performance improvements! Could you please:

Thanks!

@simakro simakro changed the title Ont update perf: Ont update; Optimizations for barcode+adapter-trimming, primer-trimming (porechop) and read correction (Canu) Jan 24, 2022
@simakro simakro requested a review from thomasbtf January 25, 2022 05:07
thomasbtf
thomasbtf approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@thomasbtf thomasbtf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Edit: I just had a closer look at get_canu_concurrency. See below.

thomasbtf
thomasbtf suggested changes Jan 25, 2022
View reviewed changes
@simakro simakro requested a review from thomasbtf January 25, 2022 08:05
@thomasbtf thomasbtf changed the title perf: Ont update; Optimizations for barcode+adapter-trimming, primer-trimming (porechop) and read correction (Canu) perf: optimisations for ont - barcode+adapter-trimming, primer-trimming (porechop) and read correction (Canu) Jan 25, 2022
@thomasbtf thomasbtf merged commit e844fc4 into master Jan 25, 2022
@thomasbtf thomasbtf deleted the ont_update branch January 25, 2022 09:56
@github-actions github-actions bot mentioned this pull request Jan 25, 2022
Merged
@alethomas alethomas restored the ont_update branch January 26, 2022 11:49
@alethomas alethomas deleted the ont_update branch January 26, 2022 11:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@thomasbtf thomasbtf thomasbtf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simakro @thomasbtf