Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Clean the component SurrogateAdvisor #73

Open
Tracked by #74
MorrisNein opened this issue Nov 8, 2023 · 1 comment
Open
Tracked by #74

Clean the component SurrogateAdvisor #73

MorrisNein opened this issue Nov 8, 2023 · 1 comment
Assignees
@ChernyakKonstantin
Labels
invalid This doesn't seem right

Comments

@MorrisNein
Copy link
Collaborator

  • The usage of other components must be moved outside, their outputs should be used as input instead. These components are: PymfeExtractor and FeaturePreprocessor
  • The usage of saved files and configs should be moved outside, and the values should be implemented as input parameters instead.
  • The class name should include model instead of pipeline
@MorrisNein MorrisNein changed the title Clean SurrogateAdvisor component Clean the component SurrogateAdvisor Nov 8, 2023
@MorrisNein MorrisNein added the invalid This doesn't seem right label Nov 8, 2023
@MorrisNein MorrisNein mentioned this issue Nov 8, 2023
Open
4 tasks
@ChernyakKonstantin
Copy link
Collaborator

ChernyakKonstantin commented Nov 15, 2023 •
edited
Loading

If there are any tests to check that all work properly after changes are applied?

@ChernyakKonstantin ChernyakKonstantin mentioned this issue Nov 15, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ChernyakKonstantin ChernyakKonstantin

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChernyakKonstantin @MorrisNein