metadata maker is generating empty URI in ServiceName element

[rhoerbe]

Pysaml2 is generating an <--ns0:ServiceName xml:lang="en"/> element for the AttributeConsumingService, which is XML schema valid, but not allowed according to SAML core:

1.3.2 URI Values
..
Unless otherwise indicated in this specification, all URI reference values used within SAML-defined elements or attributes MUST consist of at least one non-whitespace character ..

[rhoerbe]

Ah, my bad, this is not an localizedURIType, it is a localizedNameType. I got confused by the OpenSAML error message

[rhoerbe]

just learned that strings cannot be blank, like URIs:
SAML core 1.3.1 String Values:
... Unless otherwise noted in this specification or particular profiles, all strings in SAML messages MUST consist of at least one non-whitespace character

[peppelinux]

Hi @rhoerbe, I can't reproduce this in my asset, I have a SP with a correct valued ACS.
Can give more information about how to reproduce this?

[rhoerbe]

I passed on my SATOSA-related projects, so I have no dev env available in the time since. But if pysaml now is creating a proper string value, or no ServiceName at all, then the problem should be fixed.

[peppelinux]

Thank you for ack. I close this for now because It looks good to me, if someone Will update this thread I'll open It again

👍

[melanger]

@peppelinux This was probably caused by a missing name under the sp key in config, such as in the example SATOSA SAML2 backend config. I created IdentityPython/SATOSA#393 to address that.