From d0e2f70218b1a4de272729723b1542295b9c789c Mon Sep 17 00:00:00 2001 From: Stamen Stoychev Date: Wed, 9 Apr 2025 17:36:31 +0300 Subject: [PATCH 1/5] fix(grid): strict string typing the grid paging mode --- .../src/lib/grids/columns/column.component.ts | 5 +++-- .../igniteui-angular/src/lib/grids/common/enums.ts | 10 +++++----- .../src/lib/grids/grid-base.directive.ts | 4 ++-- .../src/lib/grids/grid/grid.component.ts | 9 +++++---- 4 files changed, 15 insertions(+), 13 deletions(-) diff --git a/projects/igniteui-angular/src/lib/grids/columns/column.component.ts b/projects/igniteui-angular/src/lib/grids/columns/column.component.ts index d5d1529798d..2e84966c0b5 100644 --- a/projects/igniteui-angular/src/lib/grids/columns/column.component.ts +++ b/projects/igniteui-angular/src/lib/grids/columns/column.component.ts @@ -56,7 +56,7 @@ import { IColumnVisibilityChangingEventArgs, IPinColumnCancellableEventArgs, IPi import { isConstructor, PlatformUtil } from '../../core/utils'; import { IgxGridCell } from '../grid-public-cell'; import { NG_VALIDATORS, Validator } from '@angular/forms'; -import { Size } from '../common/enums'; +import { GridPagingMode, Size } from '../common/enums'; import { ExpressionsTreeUtil } from '../../data-operations/expressions-tree-util'; const DEFAULT_DATE_FORMAT = 'mediumDate'; @@ -1422,7 +1422,8 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy, ColumnTy return this.grid.dataView .map((rec, index) => { if (!this.grid.isGroupByRecord(rec) && !this.grid.isSummaryRow(rec)) { - this.grid.pagingMode === 1 && this.grid.page !== 0 ? index = index + this.grid.perPage * this.grid.page : index = this.grid.dataRowList.first.index + index; + this.grid.pagingMode === GridPagingMode.Local && this.grid.page !== 0 ? + index = index + this.grid.perPage * this.grid.page : index = this.grid.dataRowList.first.index + index; const cell = new IgxGridCell(this.grid as any, index, this); return cell; } diff --git a/projects/igniteui-angular/src/lib/grids/common/enums.ts b/projects/igniteui-angular/src/lib/grids/common/enums.ts index 753b05d512d..233b42b1a06 100644 --- a/projects/igniteui-angular/src/lib/grids/common/enums.ts +++ b/projects/igniteui-angular/src/lib/grids/common/enums.ts @@ -103,16 +103,16 @@ export enum RowPinningPosition { Bottom } -/* mustCoerceToInt */ /** * Enumeration representing different paging modes for the grid. * - Local: The grid will use local data to extract pages during paging. * - Remote: The grid will expect pages to be delivered from a remote location and will only raise events during paging interactions. */ -export enum GridPagingMode { - Local, - Remote -} +export const GridPagingMode = /*@__PURE__*/mkenum({ + Local: 'local', + Remote: 'remote' +}); +export type GridPagingMode = (typeof GridPagingMode)[keyof typeof GridPagingMode]; /** * @hidden @internal diff --git a/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts b/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts index 4d02cd45be2..89a91c29052 100644 --- a/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts +++ b/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts @@ -3052,7 +3052,7 @@ export abstract class IgxGridBaseDirective implements GridType, /** * @hidden */ - protected _pagingMode = GridPagingMode.Local; + protected _pagingMode: GridPagingMode = GridPagingMode.Local; /** * @hidden */ @@ -4609,7 +4609,7 @@ export abstract class IgxGridBaseDirective implements GridType, */ protected _getDataViewIndex(index: number): number { let newIndex = index; - if ((index < 0 || index >= this.dataView.length) && this.pagingMode === 1 && this.page !== 0) { + if ((index < 0 || index >= this.dataView.length) && this.pagingMode === GridPagingMode.Local && this.page !== 0) { newIndex = index - this.perPage * this.page; } else if (this.gridAPI.grid.verticalScrollContainer.isRemote) { newIndex = index - this.gridAPI.grid.virtualizationState.startIndex; diff --git a/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts b/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts index 07d3b4cdb9b..819cb9b9901 100644 --- a/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts +++ b/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts @@ -23,7 +23,7 @@ import { IgxGridSummaryService } from '../summaries/grid-summary.service'; import { IgxGridSelectionService } from '../selection/selection.service'; import { IgxForOfSyncService, IgxForOfScrollSyncService } from '../../directives/for-of/for_of.sync.service'; import { IgxGridMRLNavigationService } from '../grid-mrl-navigation.service'; -import { FilterMode } from '../common/enums'; +import { FilterMode, GridPagingMode } from '../common/enums'; import { CellType, GridType, IgxGridMasterDetailContext, IgxGroupByRowSelectorTemplateContext, IgxGroupByRowTemplateContext, IGX_GRID_BASE, IGX_GRID_SERVICE_BASE, RowType } from '../common/grid.interface'; import { IgxGroupByRowSelectorDirective } from '../selection/row-selectors'; import { IgxGridCRUDService } from '../common/crud.service'; @@ -1126,7 +1126,7 @@ export class IgxGridComponent extends IgxGridBaseDirective implements GridType, } } - if (this.pagingMode === 1 && this.page !== 0) { + if (this.pagingMode === GridPagingMode.Local && this.page !== 0) { row.index = index + this.perPage * this.page; } return row; @@ -1160,7 +1160,8 @@ export class IgxGridComponent extends IgxGridBaseDirective implements GridType, */ public allRows(): RowType[] { return this.dataView.map((rec, index) => { - this.pagingMode === 1 && this.page !== 0 ? index = index + this.perPage * this.page : index = this.dataRowList.first.index + index; + this.pagingMode === GridPagingMode.Local && this.page !== 0 ? + index = index + this.perPage * this.page : index = this.dataRowList.first.index + index; return this.createRow(index); }); } @@ -1201,7 +1202,7 @@ export class IgxGridComponent extends IgxGridBaseDirective implements GridType, const row = this.getRowByIndex(rowIndex); const column = this._columns.find((col) => col.field === columnField); if (row && row instanceof IgxGridRow && !row.data?.detailsData && column) { - if (this.pagingMode === 1 && this.page !== 0) { + if (this.pagingMode === GridPagingMode.Local && this.page !== 0) { row.index = rowIndex + this.perPage * this.page; } return new IgxGridCell(this, row.index, column); From 449209c42e227887a8f8bf8209aff4ae184eba11 Mon Sep 17 00:00:00 2001 From: Stamen Stoychev Date: Thu, 10 Apr 2025 10:55:28 +0300 Subject: [PATCH 2/5] fix(grid): changing faulty enum convers --- .../src/lib/grids/columns/column.component.ts | 2 +- .../igniteui-angular/src/lib/grids/grid-base.directive.ts | 2 +- .../igniteui-angular/src/lib/grids/grid/grid.component.ts | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/projects/igniteui-angular/src/lib/grids/columns/column.component.ts b/projects/igniteui-angular/src/lib/grids/columns/column.component.ts index 2e84966c0b5..94fc87bab22 100644 --- a/projects/igniteui-angular/src/lib/grids/columns/column.component.ts +++ b/projects/igniteui-angular/src/lib/grids/columns/column.component.ts @@ -1422,7 +1422,7 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy, ColumnTy return this.grid.dataView .map((rec, index) => { if (!this.grid.isGroupByRecord(rec) && !this.grid.isSummaryRow(rec)) { - this.grid.pagingMode === GridPagingMode.Local && this.grid.page !== 0 ? + this.grid.pagingMode === GridPagingMode.Remote && this.grid.page !== 0 ? index = index + this.grid.perPage * this.grid.page : index = this.grid.dataRowList.first.index + index; const cell = new IgxGridCell(this.grid as any, index, this); return cell; diff --git a/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts b/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts index 89a91c29052..1b8260e67b0 100644 --- a/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts +++ b/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts @@ -4609,7 +4609,7 @@ export abstract class IgxGridBaseDirective implements GridType, */ protected _getDataViewIndex(index: number): number { let newIndex = index; - if ((index < 0 || index >= this.dataView.length) && this.pagingMode === GridPagingMode.Local && this.page !== 0) { + if ((index < 0 || index >= this.dataView.length) && this.pagingMode === GridPagingMode.Remote && this.page !== 0) { newIndex = index - this.perPage * this.page; } else if (this.gridAPI.grid.verticalScrollContainer.isRemote) { newIndex = index - this.gridAPI.grid.virtualizationState.startIndex; diff --git a/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts b/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts index 819cb9b9901..1451f813dbb 100644 --- a/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts +++ b/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts @@ -1126,7 +1126,7 @@ export class IgxGridComponent extends IgxGridBaseDirective implements GridType, } } - if (this.pagingMode === GridPagingMode.Local && this.page !== 0) { + if (this.pagingMode === GridPagingMode.Remote && this.page !== 0) { row.index = index + this.perPage * this.page; } return row; @@ -1160,7 +1160,7 @@ export class IgxGridComponent extends IgxGridBaseDirective implements GridType, */ public allRows(): RowType[] { return this.dataView.map((rec, index) => { - this.pagingMode === GridPagingMode.Local && this.page !== 0 ? + this.pagingMode === GridPagingMode.Remote && this.page !== 0 ? index = index + this.perPage * this.page : index = this.dataRowList.first.index + index; return this.createRow(index); }); @@ -1202,7 +1202,7 @@ export class IgxGridComponent extends IgxGridBaseDirective implements GridType, const row = this.getRowByIndex(rowIndex); const column = this._columns.find((col) => col.field === columnField); if (row && row instanceof IgxGridRow && !row.data?.detailsData && column) { - if (this.pagingMode === GridPagingMode.Local && this.page !== 0) { + if (this.pagingMode === GridPagingMode.Remote && this.page !== 0) { row.index = rowIndex + this.perPage * this.page; } return new IgxGridCell(this, row.index, column); From f7e3e73e176aa12ac99074b8d511ba2d36b4f6a1 Mon Sep 17 00:00:00 2001 From: Stamen Stoychev Date: Thu, 10 Apr 2025 15:33:47 +0300 Subject: [PATCH 3/5] test(*): removing migration test that's no longer valid --- .../migrations/update-11_1_0/index.spec.ts | 43 ------------------- 1 file changed, 43 deletions(-) diff --git a/projects/igniteui-angular/migrations/update-11_1_0/index.spec.ts b/projects/igniteui-angular/migrations/update-11_1_0/index.spec.ts index 086b6563a76..aa54dd0e083 100644 --- a/projects/igniteui-angular/migrations/update-11_1_0/index.spec.ts +++ b/projects/igniteui-angular/migrations/update-11_1_0/index.spec.ts @@ -708,47 +708,4 @@ export class CsvExportComponent { ) ).toEqual(expectedContent); }); - - it('should update GridPagingMode enum from lowerCase to TitleCase', async () => { - appTree.create( - '/testSrc/appPrefix/component/paging-test.component.ts', -`import { Component } from '@angular/core'; -import { GridPagingMode } from "igniteui-angular"; - -@Component({ - selector: "app-paging-test", - styleUrls: ["./paging-test.component.scss"], - templateUrl: "./paging-test.component.html" -}) -export class PagingComponent { - public pagingLocal: GridPagingMode = GridPagingMode.local; - public pagingRemote: GridPagingMode = GridPagingMode.remote; - constructor(){} -} -`); - - const tree = await runner - .runSchematic('migration-19', {}, appTree); - - const expectedContent = -`import { Component } from '@angular/core'; -import { GridPagingMode } from "igniteui-angular"; - -@Component({ - selector: "app-paging-test", - styleUrls: ["./paging-test.component.scss"], - templateUrl: "./paging-test.component.html" -}) -export class PagingComponent { - public pagingLocal: GridPagingMode = GridPagingMode.Local; - public pagingRemote: GridPagingMode = GridPagingMode.Remote; - constructor(){} -} -`; - expect( - tree.readContent( - '/testSrc/appPrefix/component/paging-test.component.ts' - ) - ).toEqual(expectedContent); - }); }); From 03f67aa117d9c1d86f930ba503814796079117b3 Mon Sep 17 00:00:00 2001 From: Stamen Stoychev Date: Tue, 15 Apr 2025 17:08:48 +0300 Subject: [PATCH 4/5] chore(grid): applying review comments. --- .../src/lib/grids/columns/column.component.ts | 2 +- .../igniteui-angular/src/lib/grids/grid-base.directive.ts | 6 +++--- .../igniteui-angular/src/lib/grids/grid/grid.component.ts | 6 +++--- projects/igniteui-angular/src/lib/grids/grid/grid.pipes.ts | 2 +- .../lib/grids/hierarchical-grid/hierarchical-grid.pipes.ts | 2 +- .../src/lib/grids/tree-grid/tree-grid.pipes.ts | 2 +- .../src/lib/test-utils/grid-base-components.spec.ts | 2 +- src/app/grid-remote-paging/grid-remote-paging.sample.ts | 2 +- 8 files changed, 12 insertions(+), 12 deletions(-) diff --git a/projects/igniteui-angular/src/lib/grids/columns/column.component.ts b/projects/igniteui-angular/src/lib/grids/columns/column.component.ts index 94fc87bab22..27f2e25dc0c 100644 --- a/projects/igniteui-angular/src/lib/grids/columns/column.component.ts +++ b/projects/igniteui-angular/src/lib/grids/columns/column.component.ts @@ -1422,7 +1422,7 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy, ColumnTy return this.grid.dataView .map((rec, index) => { if (!this.grid.isGroupByRecord(rec) && !this.grid.isSummaryRow(rec)) { - this.grid.pagingMode === GridPagingMode.Remote && this.grid.page !== 0 ? + this.grid.pagingMode === 'remote' && this.grid.page !== 0 ? index = index + this.grid.perPage * this.grid.page : index = this.grid.dataRowList.first.index + index; const cell = new IgxGridCell(this.grid as any, index, this); return cell; diff --git a/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts b/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts index 735a401333f..0867709bc81 100644 --- a/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts +++ b/projects/igniteui-angular/src/lib/grids/grid-base.directive.ts @@ -3052,7 +3052,7 @@ export abstract class IgxGridBaseDirective implements GridType, /** * @hidden */ - protected _pagingMode: GridPagingMode = GridPagingMode.Local; + protected _pagingMode: GridPagingMode = 'local'; /** * @hidden */ @@ -4623,7 +4623,7 @@ export abstract class IgxGridBaseDirective implements GridType, */ protected _getDataViewIndex(index: number): number { let newIndex = index; - if ((index < 0 || index >= this.dataView.length) && this.pagingMode === GridPagingMode.Remote && this.page !== 0) { + if ((index < 0 || index >= this.dataView.length) && this.pagingMode === 'remote' && this.page !== 0) { newIndex = index - this.perPage * this.page; } else if (this.gridAPI.grid.verticalScrollContainer.isRemote) { newIndex = index - this.gridAPI.grid.virtualizationState.startIndex; @@ -7268,7 +7268,7 @@ export abstract class IgxGridBaseDirective implements GridType, // eslint-disable-next-line prefer-const for (let [row, set] of selectionMap) { - row = this.paginator && (this.pagingMode === GridPagingMode.Local && source === this.filteredSortedData) ? row + (this.perPage * this.page) : row; + row = this.paginator && (this.pagingMode === 'local' && source === this.filteredSortedData) ? row + (this.perPage * this.page) : row; row = isRemote ? row - this.virtualizationState.startIndex : row; if (!source[row] || source[row].detailsData !== undefined) { continue; diff --git a/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts b/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts index 1451f813dbb..6c678f0919f 100644 --- a/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts +++ b/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts @@ -1126,7 +1126,7 @@ export class IgxGridComponent extends IgxGridBaseDirective implements GridType, } } - if (this.pagingMode === GridPagingMode.Remote && this.page !== 0) { + if (this.pagingMode === 'remote' && this.page !== 0) { row.index = index + this.perPage * this.page; } return row; @@ -1160,7 +1160,7 @@ export class IgxGridComponent extends IgxGridBaseDirective implements GridType, */ public allRows(): RowType[] { return this.dataView.map((rec, index) => { - this.pagingMode === GridPagingMode.Remote && this.page !== 0 ? + this.pagingMode === 'remote' && this.page !== 0 ? index = index + this.perPage * this.page : index = this.dataRowList.first.index + index; return this.createRow(index); }); @@ -1202,7 +1202,7 @@ export class IgxGridComponent extends IgxGridBaseDirective implements GridType, const row = this.getRowByIndex(rowIndex); const column = this._columns.find((col) => col.field === columnField); if (row && row instanceof IgxGridRow && !row.data?.detailsData && column) { - if (this.pagingMode === GridPagingMode.Remote && this.page !== 0) { + if (this.pagingMode === 'remote' && this.page !== 0) { row.index = rowIndex + this.perPage * this.page; } return new IgxGridCell(this, row.index, column); diff --git a/projects/igniteui-angular/src/lib/grids/grid/grid.pipes.ts b/projects/igniteui-angular/src/lib/grids/grid/grid.pipes.ts index 314c1e496b4..025db4b07da 100644 --- a/projects/igniteui-angular/src/lib/grids/grid/grid.pipes.ts +++ b/projects/igniteui-angular/src/lib/grids/grid/grid.pipes.ts @@ -89,7 +89,7 @@ export class IgxGridPagingPipe implements PipeTransform { constructor(@Inject(IGX_GRID_BASE) private grid: GridType) { } public transform(collection: IGroupByResult, enabled: boolean, page = 0, perPage = 15, _: number): IGroupByResult { - if (!enabled || this.grid.pagingMode !== GridPagingMode.Local) { + if (!enabled || this.grid.pagingMode !== 'local') { return collection; } const state = { diff --git a/projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.pipes.ts b/projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.pipes.ts index 46636a25880..02ec2ff7d3a 100644 --- a/projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.pipes.ts +++ b/projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.pipes.ts @@ -68,7 +68,7 @@ export class IgxGridHierarchicalPagingPipe implements PipeTransform { constructor(@Inject(IGX_GRID_BASE) private grid: GridType) { } public transform(collection: any[], enabled: boolean, page = 0, perPage = 15, _id: string, _pipeTrigger: number): any[] { - if (!enabled || this.grid.pagingMode !== GridPagingMode.Local) { + if (!enabled || this.grid.pagingMode !== 'local') { return collection; } diff --git a/projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.pipes.ts b/projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.pipes.ts index bdc03cde114..ce60f741825 100644 --- a/projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.pipes.ts +++ b/projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.pipes.ts @@ -233,7 +233,7 @@ export class IgxTreeGridPagingPipe implements PipeTransform { constructor(@Inject(IGX_GRID_BASE) private grid: GridType) { } public transform(collection: ITreeGridRecord[], enabled: boolean, page = 0, perPage = 15, _: number): ITreeGridRecord[] { - if (!enabled || this.grid.pagingMode !== GridPagingMode.Local) { + if (!enabled || this.grid.pagingMode !== 'local') { return collection; } diff --git a/projects/igniteui-angular/src/lib/test-utils/grid-base-components.spec.ts b/projects/igniteui-angular/src/lib/test-utils/grid-base-components.spec.ts index 621964458e2..d7bfcbbb9c4 100644 --- a/projects/igniteui-angular/src/lib/test-utils/grid-base-components.spec.ts +++ b/projects/igniteui-angular/src/lib/test-utils/grid-base-components.spec.ts @@ -123,7 +123,7 @@ export class PagingComponent extends GridWithSizeComponent { imports: [IgxGridComponent, IgxColumnComponent, IgxPaginatorComponent] }) export class RemotePagingComponent extends GridWithSizeComponent { - public pagingMode = GridPagingMode.Remote; + public pagingMode = 'remote'; public perPage = 3; public totalRecords = 10; public override data = SampleTestData.personJobDataFull(); diff --git a/src/app/grid-remote-paging/grid-remote-paging.sample.ts b/src/app/grid-remote-paging/grid-remote-paging.sample.ts index 8a2da80baa0..e0b82c52574 100644 --- a/src/app/grid-remote-paging/grid-remote-paging.sample.ts +++ b/src/app/grid-remote-paging/grid-remote-paging.sample.ts @@ -15,7 +15,7 @@ import { GridPagingMode, IgxButtonDirective, IgxCardComponent, IgxCardContentDir export class GridRemotePagingSampleComponent implements OnInit, AfterViewInit, OnDestroy { @ViewChild('grid1', { static: true }) public grid1: IgxGridComponent; - public mode: GridPagingMode = GridPagingMode.Remote; + public mode: GridPagingMode = 'remote'; public page = 0; public totalCount = 0; public pages = []; From 0d2d60eca5ba78592fe9953ce406c0f11d7d9dfe Mon Sep 17 00:00:00 2001 From: Stamen Stoychev Date: Tue, 15 Apr 2025 18:45:29 +0300 Subject: [PATCH 5/5] chore(*): removing unused imports --- .../igniteui-angular/src/lib/grids/columns/column.component.ts | 2 +- projects/igniteui-angular/src/lib/grids/grid/grid.component.ts | 2 +- projects/igniteui-angular/src/lib/grids/grid/grid.pipes.ts | 1 - .../src/lib/grids/hierarchical-grid/hierarchical-grid.pipes.ts | 1 - .../igniteui-angular/src/lib/grids/tree-grid/tree-grid.pipes.ts | 1 - .../src/lib/test-utils/grid-base-components.spec.ts | 1 - 6 files changed, 2 insertions(+), 6 deletions(-) diff --git a/projects/igniteui-angular/src/lib/grids/columns/column.component.ts b/projects/igniteui-angular/src/lib/grids/columns/column.component.ts index 27f2e25dc0c..dce87662e5b 100644 --- a/projects/igniteui-angular/src/lib/grids/columns/column.component.ts +++ b/projects/igniteui-angular/src/lib/grids/columns/column.component.ts @@ -56,7 +56,7 @@ import { IColumnVisibilityChangingEventArgs, IPinColumnCancellableEventArgs, IPi import { isConstructor, PlatformUtil } from '../../core/utils'; import { IgxGridCell } from '../grid-public-cell'; import { NG_VALIDATORS, Validator } from '@angular/forms'; -import { GridPagingMode, Size } from '../common/enums'; +import { Size } from '../common/enums'; import { ExpressionsTreeUtil } from '../../data-operations/expressions-tree-util'; const DEFAULT_DATE_FORMAT = 'mediumDate'; diff --git a/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts b/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts index 6c678f0919f..dbc7171abdd 100644 --- a/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts +++ b/projects/igniteui-angular/src/lib/grids/grid/grid.component.ts @@ -23,7 +23,7 @@ import { IgxGridSummaryService } from '../summaries/grid-summary.service'; import { IgxGridSelectionService } from '../selection/selection.service'; import { IgxForOfSyncService, IgxForOfScrollSyncService } from '../../directives/for-of/for_of.sync.service'; import { IgxGridMRLNavigationService } from '../grid-mrl-navigation.service'; -import { FilterMode, GridPagingMode } from '../common/enums'; +import { FilterMode } from '../common/enums'; import { CellType, GridType, IgxGridMasterDetailContext, IgxGroupByRowSelectorTemplateContext, IgxGroupByRowTemplateContext, IGX_GRID_BASE, IGX_GRID_SERVICE_BASE, RowType } from '../common/grid.interface'; import { IgxGroupByRowSelectorDirective } from '../selection/row-selectors'; import { IgxGridCRUDService } from '../common/crud.service'; diff --git a/projects/igniteui-angular/src/lib/grids/grid/grid.pipes.ts b/projects/igniteui-angular/src/lib/grids/grid/grid.pipes.ts index 025db4b07da..4f5a4238eb4 100644 --- a/projects/igniteui-angular/src/lib/grids/grid/grid.pipes.ts +++ b/projects/igniteui-angular/src/lib/grids/grid/grid.pipes.ts @@ -7,7 +7,6 @@ import { IFilteringExpressionsTree, FilteringExpressionsTree } from '../../data- import { IGroupingExpression } from '../../data-operations/grouping-expression.interface'; import { GridType, IGX_GRID_BASE } from '../common/grid.interface'; import { FilterUtil, IFilteringStrategy } from '../../data-operations/filtering-strategy'; -import { GridPagingMode } from '../common/enums'; import { ISortingExpression } from '../../data-operations/sorting-strategy'; import { IGridSortingStrategy, IGridGroupingStrategy } from '../common/strategy'; diff --git a/projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.pipes.ts b/projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.pipes.ts index 02ec2ff7d3a..fbe342841f5 100644 --- a/projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.pipes.ts +++ b/projects/igniteui-angular/src/lib/grids/hierarchical-grid/hierarchical-grid.pipes.ts @@ -1,7 +1,6 @@ import { Inject, Pipe, PipeTransform } from '@angular/core'; import { cloneArray, resolveNestedPath } from '../../core/utils'; import { DataUtil } from '../../data-operations/data-util'; -import { GridPagingMode } from '../common/enums'; import { GridType, IGX_GRID_BASE } from '../common/grid.interface'; /** diff --git a/projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.pipes.ts b/projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.pipes.ts index ce60f741825..62d6e9ba5c9 100644 --- a/projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.pipes.ts +++ b/projects/igniteui-angular/src/lib/grids/tree-grid/tree-grid.pipes.ts @@ -3,7 +3,6 @@ import { cloneArray, cloneHierarchicalArray } from '../../core/utils'; import { DataUtil } from '../../data-operations/data-util'; import { ITreeGridRecord } from './tree-grid.interfaces'; import { GridType, IGX_GRID_BASE } from '../common/grid.interface'; -import { GridPagingMode } from '../common/enums'; import { TransactionType } from '../../services/public_api'; import { IgxAddRow } from '../common/crud.service'; import { ISortingExpression } from '../../data-operations/sorting-strategy'; diff --git a/projects/igniteui-angular/src/lib/test-utils/grid-base-components.spec.ts b/projects/igniteui-angular/src/lib/test-utils/grid-base-components.spec.ts index d7bfcbbb9c4..8ac162068a9 100644 --- a/projects/igniteui-angular/src/lib/test-utils/grid-base-components.spec.ts +++ b/projects/igniteui-angular/src/lib/test-utils/grid-base-components.spec.ts @@ -3,7 +3,6 @@ import { SampleTestData } from './sample-test-data.spec'; import { ColumnDefinitions, GridTemplateStrings } from './template-strings.spec'; import { IgxGridComponent } from '../grids/grid/grid.component'; import { IgxColumnActionsComponent } from '../grids/column-actions/column-actions.component'; -import { GridPagingMode } from '../grids/common/enums'; import { IgxColumnComponent } from '../grids/columns/column.component'; import { IgxGridToolbarComponent } from '../grids/toolbar/grid-toolbar.component'; import { IgxGridToolbarHidingComponent } from '../grids/toolbar/grid-toolbar-hiding.component';