Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve soil nutrient documentation #662

Open
jacobcook1995 opened this issue Jan 8, 2025 · 2 comments · May be fixed by #752
Open

Improve soil nutrient documentation #662

jacobcook1995 opened this issue Jan 8, 2025 · 2 comments · May be fixed by #752
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@jacobcook1995
Copy link
Collaborator

The "Theory" and "Implementation" documentation of the soil nutrient pools and cycling processes is out of date and needs to be updated. This is something of a moving target as I am currently reworking this section of the code. However, I can make a start on restructuring this section of the documentation as I am doing this, so that the documentation of the final structure doesn't lag the implementation that much.

@jacobcook1995 jacobcook1995 added the documentation Improvements or additions to documentation label Jan 8, 2025
@jacobcook1995 jacobcook1995 self-assigned this Jan 8, 2025
@davidorme davidorme added this to the Soil Model Development milestone Jan 14, 2025
@hrlai hrlai self-assigned this Feb 14, 2025
@hrlai
Copy link
Collaborator

hrlai commented Feb 14, 2025

If you already has a PR in progress please feel free to let me know. Happy to edit it together. I have some suggestions, e.g., maom_desorption_rate can have a clearer description to say that it is the desorption from MAOM to LMWC. This is also a term missing from the Millennial Model, i.e., there is no $F_{ml}$ term in Equation 16 in Abramoff et al. (2018), right? I can't find out but it seems that they assumed that it is negligible, hence our very small value at 1e-05?

@jacobcook1995
Copy link
Collaborator Author

Yes I'll try and get a draft PR up tomorrow which we could then co-edit.

Something I need to make clear about is the mineral association aspect, this differs from all the model that the soil model derives from, and I need to make clear the logic behind the setup I've implemented

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
3 participants