You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The "Theory" and "Implementation" documentation of the soil nutrient pools and cycling processes is out of date and needs to be updated. This is something of a moving target as I am currently reworking this section of the code. However, I can make a start on restructuring this section of the documentation as I am doing this, so that the documentation of the final structure doesn't lag the implementation that much.
The text was updated successfully, but these errors were encountered:
If you already has a PR in progress please feel free to let me know. Happy to edit it together. I have some suggestions, e.g., maom_desorption_rate can have a clearer description to say that it is the desorption from MAOM to LMWC. This is also a term missing from the Millennial Model, i.e., there is no $F_{ml}$ term in Equation 16 in Abramoff et al. (2018), right? I can't find out but it seems that they assumed that it is negligible, hence our very small value at 1e-05?
Yes I'll try and get a draft PR up tomorrow which we could then co-edit.
Something I need to make clear about is the mineral association aspect, this differs from all the model that the soil model derives from, and I need to make clear the logic behind the setup I've implemented
The "Theory" and "Implementation" documentation of the soil nutrient pools and cycling processes is out of date and needs to be updated. This is something of a moving target as I am currently reworking this section of the code. However, I can make a start on restructuring this section of the documentation as I am doing this, so that the documentation of the final structure doesn't lag the implementation that much.
The text was updated successfully, but these errors were encountered: