Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PHP 8 compatability #19

Open
nie7321 opened this issue Feb 17, 2021 · 0 comments
Open

PHP 8 compatability #19

nie7321 opened this issue Feb 17, 2021 · 0 comments

Comments

@nie7321
Copy link

nie7321 commented Feb 17, 2021

Due to the php ~7.1 requirement in composer.json, this package is not installable on PHP 8.

However, the tests pass on 8, with a couple easy-to-fix warnings:

vagrant@homestead:~/code/SolrQueryComponent$ php --version
PHP 8.0.1 (cli) (built: Jan 13 2021 08:22:35) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.1, Copyright (c) Zend Technologies
    with Zend OPcache v8.0.1, Copyright (c), by Zend Technologies

vagrant@homestead:~/code/SolrQueryComponent$ phpunit
PHP Warning:  Private methods cannot be final as they are never overridden by other classes in /home/vagrant/code/SolrQueryComponent/vendor/phpunit/phpunit/src/Util/Configuration.php on line 176

Warning: Private methods cannot be final as they are never overridden by other classes in /home/vagrant/code/SolrQueryComponent/vendor/phpunit/phpunit/src/Util/Configuration.php on line 176
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.0.1
Configuration: /home/vagrant/code/SolrQueryComponent/phpunit.xml.dist
Error:         No code coverage driver is available

...............................................................  63 / 104 ( 60%)
.........................................                       104 / 104 (100%)

Time: 276 ms, Memory: 8.00MB

OK (104 tests, 301 assertions)

I'm happy to submit the PRs to fix this (here & in the dependent packages InterNations owns) if you'd like!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

No branches or pull requests

1 participant