Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

duplicate keys in CBOR set decoding #2965 #3340

Closed
JaredCorduan opened this issue Mar 16, 2023 · 0 comments · Fixed by #3331
Closed

duplicate keys in CBOR set decoding #2965 #3340

JaredCorduan opened this issue Mar 16, 2023 · 0 comments · Fixed by #3331
Labels
bug Something isn't working

Comments

@JaredCorduan
Copy link
Contributor

We currently allow CBOR arrays with duplicate elements to be serialized as sets (by dropping the older duplicated elements). We also currently do not allow for using the CBOR set tag 258. In the spirit of proposed CIP-80, we consider the first issues (duplicates) a serious flaw that we should fix at the next hard fork, and we consider the second issue a non-serious flaw that we should migrate away from (so start permitting the tag at the next hard fork but do not enforce it).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant