Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

field_external_uri is a magic string in a handful of places #1290

Closed
dannylamb opened this issue Sep 30, 2019 · 2 comments
Closed

field_external_uri is a magic string in a handful of places #1290

dannylamb opened this issue Sep 30, 2019 · 2 comments
Assignees
@dflitner

Comments

@dannylamb
Copy link
Contributor

We've got a constant for it in IslandoraUtils: https://github.com/Islandora-CLAW/islandora/blob/8.x-1.x/src/IslandoraUtils.php#L31

So we shouldn't be hardcoding it in JsonldTypeAlterReaction, NodeLinkHeaderSubscriber, and LinkHeaderSubscriber.

Super easy newbie ticket if there are any takers.
@dflitner
Copy link

dflitner commented Oct 2, 2019

I am on this!

@dannylamb
Copy link
Contributor Author

Resolved via 2a3b556

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@dflitner dflitner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dflitner @dannylamb