Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Localization: untranslated menu items #438

Closed
mlep opened this issue Dec 1, 2015 · 8 comments
Closed

Localization: untranslated menu items #438

mlep opened this issue Dec 1, 2015 · 8 comments

Comments

@mlep
Copy link
Contributor

mlep commented Dec 1, 2015

In JabRef 3.0 (but also using JabRef-3.1dev--snapshot--2015-12-01--master--4630d6b.jar), some menu items are not translated into French while the proper localization strings are present in the file Menu_fr.properties .
This is the case for the menu items "Cut", "Copy", "Paste".

Additionally, the menu "Check integrity" is not localized, but this may be because the proper key seems missing: we have the key "Integrity_check=V\u00e9rification_d'int\u00e9grit\u00e9"
but not "Check_integrity=".

@matthiasgeiger
Copy link
Member

I fixed the issues with "Cut", "Copy" and "Paste".

Regarding "Integrity check": We renamed "Integrity check" to "Check integrity" to use the "verb noun" style consistently - so this change is correct.

@domwass
Copy link

domwass commented Dec 1, 2015

The German translation for "Check ingegrity" in the menu now is "Prüfe Integrität." (with period). I think this should be the translation for the status bar, not for the menu for which "Integritätsprüfung" or "Integrität prüfen" would be correct.

@domwass domwass reopened this Dec 1, 2015
@mlep
Copy link
Contributor Author

mlep commented Dec 1, 2015

About the integrity check, I am fine with the decision to use "verb noun". The strange things are that 1) "Check integrity" still appears as a menu item and 2) the key
"Integrity_check=" is still in the localization file.

@matthiasgeiger
Copy link
Member

You are both right...

@mlep Can you provide me a translation for "Check integrity"? I'll add this to the menu preferences...

@mlep
Copy link
Contributor Author

mlep commented Dec 1, 2015

Check_integrity=Vérifier_l'intégrité
for French (but I guess translators for other languages are concerned, too)

@matthiasgeiger
Copy link
Member

Renamed "Integrity Check" to "Check integrity" in 68536e4 - I reused the old translations as a) they seem to use the "verb noun" style in some languages and b) the old translation is better than no translation ;-)

@stefan-kolb
Copy link
Member

Can this be closed again?

@matthiasgeiger
Copy link
Member

Yes.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants