Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ToolTip to explain color in the first column of table view #5152

Closed
buhtz opened this issue Jul 28, 2019 · 10 comments · Fixed by #5191
Closed

ToolTip to explain color in the first column of table view #5152

buhtz opened this issue Jul 28, 2019 · 10 comments · Fixed by #5191

Comments

@buhtz
Copy link

buhtz commented Jul 28, 2019

Using the JabRev 5.* dev from today. See screenshot for detailed version information.

screen

In that screenshot you also can see blue and white colored vertical bars in the first column of the table view (2 blue, 2 white and 1 without color).

What do they mean?

It should be explained with a tooltip when hovering the color.

@fdmcneill2019
Copy link

fdmcneill2019 commented Jul 29, 2019

Are there any specific explanations you want provided for each?

@buhtz
Copy link
Author

buhtz commented Jul 29, 2019

I even have no idea what the colors mean. So I do not know what could be provided here. ;)

@tobiasdiez
Copy link
Member

These are the colors of the groups that this entry belongs to. Thus a tooltip would be "Entry is part of the following groups: x, y, z."

@buhtz
Copy link
Author

buhtz commented Jul 30, 2019

Ah. In that case a tooltip as I wished first would not be the right choice I think.

Simplest solution: The color is in the first column right? Title it as "group color" is to wide of course. But you could set a tooltip "group color" to the title of the column (not the entries). The neighbor columsn (url, doi, ...) also have their own tooltip.

Alternative: Or if setting up a tooltip for each entry then I would assume color and the group name (including its path!).

Also in the column settings of the settings dialog I can not see that the first column is the group color. I was looking there first.

@fdmcneill2019
Copy link

These are the colors of the groups that this entry belongs to. Thus a tooltip would be "Entry is part of the following groups: x, y, z."

So essentially, the names of the group are the same as the color names? For example, a blue bar means that the entry belongs in the group called "blue"?

@fdmcneill2019
Copy link

@noMICROSOFTbuhtz How do I find the main source code file(s) to address this issue?

@buhtz
Copy link
Author

buhtz commented Jul 30, 2019

I am not a core developer here - just a user. I think @tobiasdiez knows the answer.

The name of the group is different from the color. I mean the tooltip should contain the name (e.g. "Science") of the group as a string and the color as a colored rectangle.

@tobiasdiez
Copy link
Member

According to the code, there should be even a tooltip

Tooltip tooltip = new Tooltip(Localization.lang("Entry is contained in the following groups:") + "\n" + matchedGroupsString);

@buhtz
Copy link
Author

buhtz commented Aug 2, 2019

@tobiasdiez Nice. Again the GUI lib is the "problem".

The tooltip araise only (but not everytime!) if the entry is selected. If not no tooltip. This is unusual and against standard behaviour of other GUI libs.

Other problem is that the tooltip disapears after some seconds. Even unusual. A tooltip should disapear only when the cursor is moved and not aver a delay.

@Siedlerchr
Copy link
Member

Thanks to @mmihuu the problem should be fixed now. there is a now an icon and a tooltip.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants