Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Nothing happens in options dialog "settings for open office" #534

Closed
teertinker opened this issue Dec 17, 2015 · 5 comments
Closed

Nothing happens in options dialog "settings for open office" #534

teertinker opened this issue Dec 17, 2015 · 5 comments
Labels
component: ui [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs
Milestone

Comments

@teertinker
Copy link
Contributor

Got to "Settings"-> "External Programs" click on "Settings for open office"

-> nothing happens. Clicking on the other external programs opens a dialog. Should probably be grayed or something else.

@matthiasgeiger matthiasgeiger added [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs component: ui labels Dec 17, 2015
@matthiasgeiger matthiasgeiger added this to the v3.1 milestone Dec 17, 2015
@matthiasgeiger
Copy link
Member

Confirmed. Another NullPointerException...

@oscargus
Copy link
Contributor

Which isn't surprising considering the code:

    @Override
    public JPanel getSettingsPanel() {
        return null;
        /*if (settings == null)
            initSettingsPanel();
        return settings;*/
    }

I do not have time to look more into it (as in creating a branch, uncomment, and test) but should be rather straightforward (although I guess it might be commented for a reason...).

@matthiasgeiger
Copy link
Member

😱

@oscargus oscargus modified the milestones: v3.2, v3.1 Dec 27, 2015
@koppor koppor modified the milestones: v3.2, v3.3 Jan 8, 2016
@stefan-kolb
Copy link
Member

@oscargus Is this treated in #602 somehow?

@oscargus
Copy link
Contributor

oscargus commented Feb 2, 2016

Yes, the button is removed from the preference dialog and there's no PushToApplication for OpenOffice anymore (only through the sidepane), so I close it now.

@oscargus oscargus closed this as completed Feb 2, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
component: ui [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Development

No branches or pull requests

5 participants