From d08b1f8a04464ec236b5a93b7a3b340f6dcb8e85 Mon Sep 17 00:00:00 2001 From: Dawid Motyka Date: Thu, 20 Feb 2020 14:43:40 +0100 Subject: [PATCH 1/2] Fix: setting BibEntry to "changed" state before setting a new entry type fixes #5905 --- src/main/java/org/jabref/model/entry/BibEntry.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/jabref/model/entry/BibEntry.java b/src/main/java/org/jabref/model/entry/BibEntry.java index 8d5fcb68207..bfe7cadc8c8 100644 --- a/src/main/java/org/jabref/model/entry/BibEntry.java +++ b/src/main/java/org/jabref/model/entry/BibEntry.java @@ -359,8 +359,8 @@ public Optional setType(EntryType newType, EntriesEventSource event return Optional.empty(); } - this.type.setValue(newType); changed = true; + this.type.setValue(newType); FieldChange change = new FieldChange(this, InternalField.TYPE_HEADER, oldType.getName(), newType.getName()); eventBus.post(new FieldChangedEvent(change, eventSource)); From 6724f8226c766470456bddf66967a1ae744a98d4 Mon Sep 17 00:00:00 2001 From: Dawid Motyka Date: Fri, 21 Feb 2020 11:40:59 +0100 Subject: [PATCH 2/2] Update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ae9e8816e5d..ad05df3cb63 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -37,6 +37,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `# - We fixed an issue where an entry containing an external filename with curly braces could not be saved. Curly braces are now longer allowed in filenames. [#5899](https://github.com/JabRef/jabref/issues/5899) - We fixed an issue where changing the type of an entry did not update the main table. [#5906](https://github.com/JabRef/jabref/issues/5906) - We fixed an issue where opening a library from the recent libraries menu was not possible. [#5939](https://github.com/JabRef/jabref/issues/5939) +- We fixed an issue where changing entry type doesn't always work when biblatex source is shown. [#5905](https://github.com/JabRef/jabref/issues/5905) ### Removed