Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

prep for release 1.3 #18

Open
3 tasks done
mhw-at-yg opened this issue Feb 12, 2020 · 10 comments
Open
3 tasks done

prep for release 1.3 #18

mhw-at-yg opened this issue Feb 12, 2020 · 10 comments
Assignees

Comments

@mhw-at-yg
Copy link
Collaborator

mhw-at-yg commented Feb 12, 2020

Hello, new maintainer Matt Wilkie here. I'm planning to issue a new release, chiefly to take advantage of the support for ArcGIS Pro from #16 courtesy of @logan-pugh. Please raise anything you think should be addressed or included, either as comment here or new issue.

I treat 1st comment as wiki and update periodically to reflect issue status

@mhw-at-yg mhw-at-yg self-assigned this Feb 12, 2020
@logan-pugh
Copy link
Contributor

logan-pugh commented Feb 13, 2020

I think it would be good to standardize on a code style/linter; I like flake8 (with a few rules turned off), and 4 spaces instead of 2.

I'll submit another PR with my suggestions. edit: #19

@logan-pugh
Copy link
Contributor

See also #20 and #21 -- I think that's it from me 😉

@mhw-at-yg
Copy link
Collaborator Author

All of the things identified for 1.3 release have been done. @logan-pugh you've done most of the new feature work, do you see anything else that should be done before making a release?

@mhw-at-yg
Copy link
Collaborator Author

I pushed a release candidate 1.3.0rc tag.

@jesegal
Copy link

jesegal commented May 14, 2020

I tried this version with pyinstaller and got the failure below during runtime.
Am I jumping the gun, so to speak?

File "site-packages\archook_init_.py", line 14, in
File "site-packages\archook_init_.py", line 12, in get_version
File "site-packages\pkg_resources_init_.py", line 482, in get_distribution
File "site-packages\pkg_resources_init_.py", line 358, in get_provider
File "site-packages\pkg_resources_init_.py", line 901, in require
File "site-packages\pkg_resources_init_.py", line 787, in resolve
pkg_resources.DistributionNotFound: The 'archook' distribution was not found and is required by the application

@mhw-at-yg
Copy link
Collaborator Author

@jesegal nope, not jumping the gun, please open as a a new issue though.

@cooperjaXC
Copy link

@mhw-at-yg Any updates on this? I dutifully followed advice from #31 embedding this neat tool into my own packages and products, and it is working great. As of now though, the PyPi version is still v1.2 from 2017. Even if the current v1.3.dev0 is pushed, there are valuable ArcGIS Pro enhancements that would be great to have available through the usual pip install method. It may fix other issues like #30 too. Appreciate the help.

@mhw-at-yg
Copy link
Collaborator Author

thanks for the nudge @cooperjaXC . I've added this to my to-look-at for tomorrow

@maphew
Copy link

maphew commented Sep 14, 2023

@cooperjaXC if you pip install from github does that still work for you? I'm not making much headway against #34, but maybe that only affects conda users like myself and isn't a general issue.

 pip install https://github.com/JamesRamm/archook/archive/refs/heads/master.zip

@cooperjaXC
Copy link

@cooperjaXC if you pip install from github does that still work for you? I'm not making much headway against #34, but maybe that only affects conda users like myself and isn't a general issue.

 pip install https://github.com/JamesRamm/archook/archive/refs/heads/master.zip

@maphew It works fine for me, but I don't conda install, I only pip install using the python interpreter that comes with anaconda. I use the command suggested in #31 (comment), and it works in both command line and requirements.txt installations. No numpy errors.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants