Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add in a finalizer to garbage collect the internal C model #24

Closed
JamieMair opened this issue Aug 11, 2023 · 0 comments · Fixed by #31
Closed

Add in a finalizer to garbage collect the internal C model #24

JamieMair opened this issue Aug 11, 2023 · 0 comments · Fixed by #31
Assignees
@JamieMair
Labels
bug Something isn't working enhancement New feature or request
Milestone
initial-beta

Comments

@JamieMair
Copy link
Owner

Follow https://github.com/Lyceum/MuJoCo.jl/blob/dd345bf5578e375a14d467c7761913193e3be5b0/src/jlmodel.jl#L98-L104 to automatically add a garbage collector to the struct objects.

It is worth considering whether this should be done on this struct, as it may be unclear when this object is freed.
@JamieMair JamieMair added bug Something isn't working enhancement New feature or request labels Aug 11, 2023
@JamieMair JamieMair self-assigned this Aug 11, 2023
@JamieMair JamieMair added this to the initial-beta milestone Aug 11, 2023
@JamieMair JamieMair mentioned this issue Aug 12, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@JamieMair JamieMair

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
initial-beta
Development

Successfully merging a pull request may close this issue.

Add in gc support JamieMair/MuJoCo.jl
1 participant
@JamieMair